Fix strange bug with regexes#25
Open
gilbert wants to merge 1 commit intoeugeneware:masterfrom
universal-systems:fix/global-regexes
Open
Fix strange bug with regexes#25gilbert wants to merge 1 commit intoeugeneware:masterfrom universal-systems:fix/global-regexes
gilbert wants to merge 1 commit intoeugeneware:masterfrom
universal-systems:fix/global-regexes
Conversation
For some reason the regex isn't isn't updating x as it should. I tried isolating, but no luck. This fix is a bit more code, but it's good according to the spec, so there should be no issues with backwards compatibility.
Collaborator
|
What exactly does it fix? Where is the updated test? |
Author
|
lastIndex updated as it should after one I will add a test when I get the chance. I just wanted to throw this up before I forgot about it. |
|
regular expressions don't work for me with or without this change.. I get:
this happens with the regex examples in |
Collaborator
|
@jaruba This will be merged once a test has been added. |
Collaborator
|
@mindeavor can you add a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason the regex isn't isn't updating x as it should.
I tried isolating, but no luck.
This fix is a bit more code, but it's good according to the spec,
so there should be no issues with backwards compatibility.